-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] account_operating_unit #596
[16.0] [MIG] account_operating_unit #596
Conversation
… view in report. Other minor fixes.
…f setting an inter-OU accounts triggers from other modules when creating companies
* Add management of payments using operating units * Trial Balance by operating units * Improve tests
Currently translated at 100.0% (26 of 26 strings) Translation: operating-unit-15.0/operating-unit-15.0-account_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-15-0/operating-unit-15-0-account_operating_unit/es_MX/
/ocabot migration account_operating_unit |
2a597f3
to
aa19afb
Compare
@AaronHForgeFlow can you review this PR, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall works ok. Just would like to attend some comments
<field name="inherit_id" ref="account.view_account_journal_form" /> | ||
<field name="arch" type="xml"> | ||
<field name="company_id" position="after"> | ||
<field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see this field in journals in runbot. Can you check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the normal company_id field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the field appears twice on the form definition, first globally and invisible, second with a groups restriction, and we want to use the second one. I suggest changing the anchor point for the extension (see suggested change), as I'm not sure it's legit to have an anchor on a field which is group-restricted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aa19afb
to
2a84a5d
Compare
Can you please include this? #616 |
<field name="inherit_id" ref="account.view_account_journal_form" /> | ||
<field name="arch" type="xml"> | ||
<field name="company_id" position="after"> | ||
<field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the field appears twice on the form definition, first globally and invisible, second with a groups restriction, and we want to use the second one. I suggest changing the anchor point for the extension (see suggested change), as I'm not sure it's legit to have an anchor on a field which is group-restricted.
<field name="inherit_id" ref="account.view_account_journal_form" /> | ||
<field name="arch" type="xml"> | ||
<field name="company_id" position="after"> | ||
<field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include this? #610 Thanks in advance!. |
Will this continue?, I've tried installing this and does't work :( |
@raulovallet If you fixed it you can create a new PR as this one seems stale |
In account_move_view there is still a reference to account_analytic_id, whereas that field is not in account_move_line anymore |
I propose to supersede this with #656 |
Superseded |
Includes PRs:
#616
#610